Skip to content

chore: ensure metrics are correctly exposed #701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Oct 30, 2025
Merged

chore: ensure metrics are correctly exposed #701

merged 12 commits into from
Oct 30, 2025

Conversation

@xeniape
Copy link
Member

@xeniape xeniape commented Oct 15, 2025

Description

Part of stackabletech/issues#747
This PR adds a metrics service with the additional Prometheus annotations. It also adds some documentation on monitoring for the TLS case since, similar to NiFi, HBase also exposes metrics behind a port which gets secured by TLS

Follow up monitoring Stack PR because moving to the metrics service, the port name changed: stackabletech/demos#316

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@xeniape xeniape self-assigned this Oct 15, 2025
This was referenced Oct 15, 2025
Merged
Open
@xeniape xeniape moved this to Development: Waiting for Review in Stackable Engineering Oct 15, 2025
Techassi
Techassi reviewed Oct 17, 2025
View reviewed changes
Copy link
Member

@Techassi Techassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good to me, just some minor suggestions and a few questions.

I only looked at the Rust code - let me know if I should look at the docs as well.

@Techassi Techassi moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Oct 17, 2025
@sbernauer sbernauer assigned maltesander and unassigned xeniape Oct 20, 2025
@maltesander maltesander requested a review from Techassi October 27, 2025 13:22
Techassi
Techassi reviewed Oct 29, 2025
View reviewed changes
@maltesander @Techassi
Apply suggestions from code review
b562ea9 
Co-authored-by: Techassi <git@techassi.dev>
@maltesander maltesander requested a review from Techassi October 29, 2025 10:41
@maltesander maltesander enabled auto-merge October 30, 2025 09:34
@maltesander maltesander added this pull request to the merge queue Oct 30, 2025
Merged via the queue into main with commit 7136ca2 Oct 30, 2025
17 checks passed
@maltesander maltesander deleted the chore/ensure-metrics-correctly-exposed branch October 30, 2025 09:47
@maltesander maltesander moved this from Development: In Review to Development: Done in Stackable Engineering Oct 30, 2025
@lfrancke lfrancke moved this from Development: Done to Acceptance: In Progress in Stackable Engineering Nov 4, 2025
@lfrancke
Copy link
Member

lfrancke commented Nov 4, 2025

Could you please add release notes?

@maltesander
Copy link
Member

maltesander commented Nov 5, 2025

Release snippet

Previously, the hbase-operator did not expose Prometheus annotations containing the http(s) scheme or the metrics path and port. This was added in this PR and allows custom relabel configs in Prometheus to use these annotations to scrape the metric endpoints.
The `prometheus.io/scrape` label is now only available on the `metrics` Service (instead of the `headless` service), which uses `metrics` as the port name instead of the previous `ui-http`/`ui-https` port name.

@lfrancke lfrancke added release-note Denotes a PR that will be considered when it comes time to generate release notes. release/25.11.0 labels Nov 5, 2025
@lfrancke lfrancke moved this from Acceptance: In Progress to Done in Stackable Engineering Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maltesander maltesander maltesander left review comments

@Techassi Techassi Techassi approved these changes

Assignees

@maltesander maltesander

Labels

release/25.11.0 release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

Stackable Engineering
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@xeniape @lfrancke @maltesander @Techassi